Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added hvd tests to checkpoint #2192

Merged
merged 4 commits into from
Sep 15, 2021
Merged

Added hvd tests to checkpoint #2192

merged 4 commits into from
Sep 15, 2021

Conversation

Ishan-Kumar2
Copy link
Contributor

Fixes #2101

Description:
Added hvd tests to checkpoint
Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@Ishan-Kumar2 Ishan-Kumar2 marked this pull request as draft September 13, 2021 11:46
@Ishan-Kumar2
Copy link
Contributor Author

@vfdev-5 could you have a look at the results of the test run? These tests which are failing seem to not be related to this PR. This is the one I have added

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Sep 14, 2021 •
edited
Loading

@Ishan-Kumar2 thanks for pinging. I restarted HVD tests, let's see.

By the way, if you would like a review please remove "draft" mark

@Ishan-Kumar2 Ishan-Kumar2 marked this pull request as ready for review September 14, 2021 10:42
vfdev-5
vfdev-5 approved these changes Sep 15, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @Ishan-Kumar2 ! LGTM

@vfdev-5 vfdev-5 enabled auto-merge (squash) September 15, 2021 20:06
@vfdev-5 vfdev-5 merged commit 4e0993c into pytorch:master Sep 15, 2021
@Ishan-Kumar2 Ishan-Kumar2 deleted the checkpoint_hvd branch September 16, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing distributed tests to core handlers
2 participants
@Ishan-Kumar2 @vfdev-5