Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved ParamScheduler tests to core #2136

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Moved ParamScheduler tests to core #2136

merged 2 commits into from
Aug 4, 2021

Conversation

KickItLikeShika
Copy link
Contributor

Fixes #2134

Moved ParamScheduler tests from contrib to core via git mv and added conftest at handlers module.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

vfdev-5
vfdev-5 approved these changes Aug 4, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KickItLikeShika !

@vfdev-5 vfdev-5 closed this Aug 4, 2021
@vfdev-5 vfdev-5 reopened this Aug 4, 2021
@vfdev-5 vfdev-5 merged commit 6eafed3 into pytorch:master Aug 4, 2021
@KickItLikeShika KickItLikeShika deleted the move-param-scheduler-tests branch August 4, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move LRFinder and ParamScheduler tests
2 participants
@KickItLikeShika @vfdev-5