Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error in DistributedProxySampler when sampler is already a DistributedSampler #2120

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Raise error in DistributedProxySampler when sampler is already a DistributedSampler #2120

merged 2 commits into from
Jul 20, 2021

Conversation

schuhschuh
Copy link
Contributor

@schuhschuh schuhschuh commented Jul 20, 2021 •
edited
Loading

Raise TypeError when sampler passed on to DistributedProxySampler is of type DistributedSampler. See #2118.

@github-actions github-actions bot added the module: distributed Distributed module label Jul 20, 2021
@schuhschuh schuhschuh mentioned this pull request Jul 20, 2021
Merged
3 tasks
vfdev-5
vfdev-5 approved these changes Jul 20, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @schuhschuh !

@vfdev-5 vfdev-5 merged commit 0e3e966 into pytorch:master Jul 20, 2021
@schuhschuh schuhschuh deleted the 2118-raise-error-when-wrapping-distributed-sampler branch July 20, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
module: distributed Distributed module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schuhschuh @vfdev-5