Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FID pytorch Old version and Windows Fix #2061

Merged
merged 7 commits into from
Jun 18, 2021
Merged

FID pytorch Old version and Windows Fix #2061

merged 7 commits into from
Jun 18, 2021

Conversation

gucifer
Copy link
Contributor

@gucifer gucifer commented Jun 17, 2021

Fixes #2059

Description:
Fixed Errors in old version of pytorch and windows for FID.
Link to the windows error:
https://app.circleci.com/pipelines/github/pytorch/ignite/1926/workflows/4d0d4aa5-0383-43dc-9d1c-08557be2c3c6
Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: metrics Metrics module label Jun 17, 2021
@vfdev-5 vfdev-5 requested review from sdesrozis and trsvchn June 17, 2021 12:47
@trsvchn
Copy link
Collaborator

trsvchn commented Jun 17, 2021

It seems Ok, but let me try to run it in my fork by triggering that workflow for all version

@trsvchn
Copy link
Collaborator

trsvchn commented Jun 17, 2021

Here we go, testing all pytorch versions in a fork: trsvchn#18

@gucifer, tests are still failing, see:

https://github.com/trsvchn/ignite/actions/runs/947459025

@gucifer
Copy link
Contributor Author

gucifer commented Jun 18, 2021

Here we go, testing all pytorch versions in a fork: trsvchn#18

@gucifer, tests are still failing, see:

https://github.com/trsvchn/ignite/actions/runs/947459025

Reduced checking precision to 6 digits.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jun 18, 2021

@trsvchn why we still have mnist issues here : https://github.com/pytorch/ignite/pull/2061/checks?check_run_id=2856362717#step:9:319 if we are using our own storage ?

@vfdev-5 vfdev-5 reopened this Jun 18, 2021
@vfdev-5 vfdev-5 merged commit f240e6e into pytorch:master Jun 18, 2021
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jun 18, 2021

@gucifer thanks for the fix!

vfdev-5 added a commit that referenced this pull request Jun 23, 2021
vfdev-5 added a commit that referenced this pull request Jun 24, 2021
vfdev-5 added a commit that referenced this pull request Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: metrics Metrics module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduled workflow failed
3 participants