Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] py.test -> pytest #1480

Merged
merged 10 commits into from
Nov 30, 2020
Merged

[tests] py.test -> pytest #1480

merged 10 commits into from
Nov 30, 2020

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Nov 28, 2020 •
edited
Loading

Description: change py.test to pytest. pytest is recommended over py.test, just to be future-proof.

The issue with the 'other tool' has been resolved for some time now, so from pytest 3.0 we will supported and recommend use of pytest as the main command instead of py.test. It's possible that in future we will deprecate py.test and potentially even remove it.

pytest-dev/pytest#1629 (comment)

@vfdev-5

vfdev-5
vfdev-5 approved these changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ydcjeff !

@vfdev-5 vfdev-5 merged commit c48d626 into pytorch:master Nov 30, 2020
@ydcjeff ydcjeff deleted the ci/pytest branch November 30, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydcjeff @vfdev-5