-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise friendly errors in case of num_epochs
is less than num_warmup_epochs
in CIFAR10 and Transformers examples
#2207
Comments
Hey , i would like to work on this issue. Can you guide me further?! on what needs to be done🙂 |
Hey @himanshu007-creator, thanks a lot for showing interest, we have these 2 examples:
in both, if the num_epochs is less the num_warmup_epochs, the error in the description will be raised, |
Please brief me about the issue a little more. I'll work on this issue. |
Hi @FarehaNousheen, please check the comment above #2207 (comment), it explains what we need to do in depth. If you still can't get what we need to do, please ping me on discord. |
Hey @KickItLikeShika, I think adding an assertion can solve this issue. Can you assign this to me? |
Hey @KickItLikeShika, I think I've made the necessary changes in three of the files to raise an user friendly message when |
- Edited to raise friendly errors if num_epochs is less than num_warmup_epochs - Edited main.py in directories cifar10, cifar10_qat and transformers.
@DebarshiChanda @theory-in-progress to be fair if someone is assigned to the issue his/her PR has higher prio (conditioned also by the time it takes to work on the issue). Thanks a lot to you both on working on this tiny issue ! In this particular case, @theory-in-progress 's PR looks better and we'll proceed with it. |
Of course! sorry for barging in... Thanks for the opportunity @vfdev-5! I'm happy to work on this issue |
- Formatted according to guidelines.
* Related to #2207: Friendly Errors (#2207) - Edited to raise friendly errors if num_epochs is less than num_warmup_epochs - Edited main.py in directories cifar10, cifar10_qat and transformers. * Friendly Messages #2207 - Formatted according to guidelines. * Edited according to a few suggestions. * Edited according to a few suggestions. * Edited according to a few suggestions. * Code Formatting * Edited to raise error if num_epochs >= num_warmup_epochs * Code Formatting Co-authored-by: vfdev <[email protected]>
I was trying to benchmark
torch.inference_mode
vstorch.no_grad
on CIFAR10 example, so I just wanted to run for 3 epochs and average the benchmarks, the default warmup epochs is 4, so the scheduler will raise this error, which is not very clear to new usersSo I suggest to check
num_epochs
vsnum_warmup_epochs
insiderun
method and raise more clear error message for the users.The text was updated successfully, but these errors were encountered: