Replace lltm with myaddmul; update to new custom ops APIs #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're replacing lltm with myaddmul(a: Tensor, b: Tensor, c: float), which just does a*b+c. This simplification allows us to focus on the operator registration instead of get lost in the details of the complicated lltm kernels. Test Plan: - tests [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
May 24, 2024
We're replacing lltm with myaddmul(a: Tensor, b: Tensor, c: float), which just does a*b+c. This simplification allows us to focus on the operator registration instead of get lost in the details of the complicated lltm kernels. Test Plan: - tests ghstack-source-id: 8fef757fc6863bc2a7b495cca013e49d71f355b1 Pull Request resolved: #94
We're replacing lltm with myaddmul(a: Tensor, b: Tensor, c: float), which just does a*b+c. This simplification allows us to focus on the operator registration instead of get lost in the details of the complicated lltm kernels. Test Plan: - tests [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
May 24, 2024
We're replacing lltm with myaddmul(a: Tensor, b: Tensor, c: float), which just does a*b+c. This simplification allows us to focus on the operator registration instead of get lost in the details of the complicated lltm kernels. Test Plan: - tests ghstack-source-id: dbf9af17fe0d66139320f45e5ed76a6331faefce Pull Request resolved: #94
|
Uh that's not how to land it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We're replacing lltm with myaddmul(a: Tensor, b: Tensor, c: float),
which just does a*b+c. This simplification allows us to focus on the
operator registration instead of get lost in the details of the
complicated lltm kernels.
Test Plan: