Adding new cmake/scikitbuild core based workflow #85
Conversation
|
Is this repo still being updated ? Last pushed commit was 5 years ago, so I though it was mainly archived, and seeing a Meta employee submitting a new PR after all this time is weird. Anyway, I suppose it's still very early development since I can see all sorts of The introduction of a Makefile is actually very interesting, but I suppose the tutorial should mention that somewhere as well |
|
@ClementPinard This repo has been archived for some number of time. There has been an influx of new cpp/cuda extensions in the PyTorch Community; flash-attention, mamba, bitsandbytes... One common problem is that extensions dont interact correctly with torch.compile. @zou3519 and I are going to work on updating this repo to provide clean templates for users. The state of this PR is still very drafty |
drisspg
changed the title
| *.cubin | ||
| *.fatbin | ||
| build/** | ||
| driss_torch/lib/** |
| build/** | ||
| driss_torch/lib/** | ||
| compile_commands.json | ||
| benchmarks/data |
| - ufmt == 2.1.0 | ||
| - libcst == 1.0.1 | ||
|
|
||
| # missing host field? |
| find_package(Torch REQUIRED CONFIG) | ||
|
|
||
| # simple_cuda source files | ||
| file(GLOB_RECURSE CU_SOURCES csrc/*.cu) |
There was a problem hiding this comment.
not some conditionals on building cuda sources
| ) | ||
|
|
||
| # cache CUDA_ARCHITECTURES, which seems to be reset by Torch | ||
| set(TMP_STORE_CUDA_ARCHITECTURES "${CMAKE_CUDA_ARCHITECTURES}") |
There was a problem hiding this comment.
I dont think I need this, however pytorch does deviate from regualre cuda cmake builds
| MESSAGE(STATUS "CPP_SOURCES: ${CPP_SOURCES}") | ||
|
|
||
| add_library(${SKBUILD_PROJECT_NAME} SHARED | ||
| ${CU_SOURCES} |
| # simple_cuda source files | ||
| file(GLOB_RECURSE CU_SOURCES csrc/*.cu) | ||
| file(GLOB_RECURSE CPP_SOURCES csrc/*.cpp) | ||
| MESSAGE(STATUS "CU_SOURCES: ${CU_SOURCES}") |
| lib_path = Path(__file__).parent / "lib" / "libextension_cpp.so" | ||
| torch.ops.load_library(str(lib_path.resolve())) | ||
| torch.ops.load_library(lib_path) | ||
| # torch.ops.import_module("my_extension.abstract_impls") |
There was a problem hiding this comment.
need to right correct abstract impls
|
|
||
| # Specify CMake defines: | ||
| [tool.scikit-build.cmake.define] | ||
| TORCH_CUDA_ARCH_LIST="9.0" |
There was a problem hiding this comment.
this should be more generic by default
No description provided.