Skip to content

Conversation

@YufengShi-dudu
Copy link
Collaborator

@YufengShi-dudu YufengShi-dudu commented Mar 13, 2025

  1. Implement a pass ConvertAnyDefaultDimDimsPass to decompose any.default, any.dim and any.dims into a sequence of any.dim with keepdim=True and a squeeze_copy.dims if needed

  2. Implement a NodeVisitor to lower any.dim to REDUCE_ANY in TOSA

  3. Fix the failures in Arm backend: Add TOSA support for logical not #9128

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

1. Implement a pass ConvertAnyDefaultDimDimsPass to decompose
   any.default, any.dim and any.dims into a sequence of any.dim
   with keepdim=True and a squeeze_copy.dims if needed

2. Implement a NodeVisitor to lower any.dim to REDUCE_ANY in TOSA

3. Fix the failures in pytorch#9128

Change-Id: Ifb6672f2c017cd7365e76319795290a36909657c
Signed-off-by: Yufeng Shi <[email protected]>
@YufengShi-dudu YufengShi-dudu added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Mar 13, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9222

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Pending, 1 Unrelated Failure

As of commit 5f2d0bb with merge base 42d3952 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@per per self-requested a review March 13, 2025 11:26
@per per merged commit 28a8954 into pytorch:main Mar 13, 2025
121 of 124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants