Replace shim/ with facebook/buck2-shims-meta submodule #8656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8656
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 9 PendingAs of commit a241620 with merge base 2859e47 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Feb 24, 2025
After the recent move of most things in shim to shim_et, shim/ was mostly an outdated version of buck2-shims-meta. Now it is buck2-shims-meta. Test Plan: regular GitHub CI on this rev (cmake is still dependent on buck right now) ghstack-source-id: 31c6dee ghstack-comment-id: 2679930875 Pull Request resolved: #8656
facebook-github-bot
added
the
CLA Signed
swolchok
added
the
release notes: build
Contributor
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
larryliu0820
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the recent move of most things in shim to shim_et, shim/ was mostly an outdated version of buck2-shims-meta. Now it is buck2-shims-meta.
Test Plan: regular GitHub CI on this rev (cmake is still dependent on buck right now)