Copy tokenizer.model in Android benchmark spec #7463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7463
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dfdd704 with merge base 9a884a8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
huydhn
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
guangy10
approved these changes
Dec 31, 2024
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this failure when testing #7461 in which the export model
meta-llama/Llama-3.2-1Bincludestokenizer.modelinstead oftokenizer.binhttps://github.com/pytorch/executorch/actions/runs/12553877667/job/35002446700#step:10:54I vaguely remember seeing @guangy10 did a similar fix before in one of his PRs, but it's clear that the spec doesn't handle this case correctly yet.
Testing
meta-llama/Llama-3.2-1B,mv2,stories110M: https://github.com/pytorch/executorch/actions/runs/12562651135llamawithxnnpackandqnn_q8: https://github.com/pytorch/executorch/actions/runs/12554514627