Skip to content

Conversation

@oscarandersson8218
Copy link
Collaborator

Rename inputs to example_inputs to differentiate between what's used as test data and what's used as example/calibration data.

Change-Id: Ibe6e65fd3f6ec14a8f27fe2270595a3835b1e038

Rename inputs to example_inputs to differentiate between what's used as
test data and what's used as example/calibration data.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: Ibe6e65fd3f6ec14a8f27fe2270595a3835b1e038
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3800

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 1054c5e with merge base 13ba3a7 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2024
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Jun 3, 2024
@digantdesai digantdesai requested a review from mcr229 June 3, 2024 14:06
@digantdesai
Copy link
Contributor

differentiate between what's used as test data and what's used as example/calibration data.

Sorry I still don't understand the motivation. But if it is just a rename then sure.

@oscarandersson8218
Copy link
Collaborator Author

differentiate between what's used as test data and what's used as example/calibration data.

Sorry I still don't understand the motivation. But if it is just a rename then sure.

@digantdesai Yes, it's just a renaming. Prior to #2442, run_method() would use Tester.inputs if no inputs were provided to the function, but that's no longer the case. Tester.inputs is only used as example/calibration data (unless I'm missing something).

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@digantdesai merged this pull request in 8c70a50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants