Update setup.sh for tokenizer selection #3207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3207
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 5863d1a with merge base 8dc54d5 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Summary: For LLAMA3, users need to use tiktoken. Add a option to load from env var. Differential Revision: D56374673
kirklandsign
force-pushed
the
android-llama3
branch
from
241e9d6 to
5863d1a
Compare
Contributor
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cccclai
approved these changes
Apr 22, 2024
Contributor
|
@kirklandsign merged this pull request in 1a93dee. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For LLAMA3, users need to use tiktoken. Add a option to load from env var.
Next step: Remove 3P deps from extension/android, but use llama_runner directly
Differential Revision: D56430637