Add int16 support to aten_bridge #3069
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3069
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit abecb73 with merge base 9931301 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56199304 |
Summary: Running an executorch program via pybindings requires the aten_bridge. This currently fails if the model uses the `int16` dtype. This diff adds support for the type by adding it to the conversion switch statements. Differential Revision: D56199304
Vysarat
force-pushed
the
export-D56199304
branch
from
d0a1914 to
abecb73
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56199304 |
tarun292
approved these changes
Apr 16, 2024
Contributor
|
This pull request has been merged in eb664a0. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Running an executorch program via pybindings requires the aten_bridge. This currently fails if the model uses the
int16dtype. This diff adds support for the type by adding it to the conversion switch statements.Differential Revision: D56199304