Update method name for tester #3016
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3016
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Unrelated FailuresAs of commit 38d04b6 with merge base 057e432 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56072265 |
mcr229
approved these changes
Apr 12, 2024
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Apr 12, 2024
Summary: Method name update Reviewed By: mcr229 Differential Revision: D56072265
digantdesai
force-pushed
the
export-D56072265
branch
from
43b4573 to
7767eb1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56072265 |
digantdesai
force-pushed
the
export-D56072265
branch
from
7767eb1 to
55fab27
Compare
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Apr 15, 2024
Summary: Method name update Reviewed By: mcr229 Differential Revision: D56072265
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56072265 |
Summary: Method name update Reviewed By: mcr229 Differential Revision: D56072265
digantdesai
force-pushed
the
export-D56072265
branch
from
55fab27 to
38d04b6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56072265 |
Collaborator
|
LGTM, but I have fixed the issues in a slightly different way in #2991. I'd prefer that since it's using the new and shiny method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Method name update
Differential Revision: D56072265