Fixes for constant_prop_pass #2967
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2967
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 194b751 with merge base a983ebc ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55942686 |
Summary: The constant_prop_pass didn't properly propagate constants when there were simple primitives in the argument set. Extend it to see floats, ints, strings, etc. as constant functions. This allows this pass to fold additional things like quantize functions on weights. Sometimes users don't want that, so allow them to use a lambda to skip some nodes. Differential Revision: D55942686
dulinriley
force-pushed
the
export-D55942686
branch
from
8867bf3 to
194b751
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55942686 |
Contributor
Author
|
My bad I didn't realize that someone else made a PR just a few hours ago: I'll close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The constant_prop_pass didn't properly propagate constants when there were
simple primitives in the argument set. Extend it to see floats, ints, strings, etc.
as constant functions.
This allows this pass to fold additional things like quantize functions on weights.
Sometimes users don't want that, so allow them to use a lambda to skip
some nodes.
Differential Revision: D55942686