Skip to content

Custom ops API small fixes #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
larryliu0820 wants to merge 1 commit into from
Closed

Custom ops API small fixes #2936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions extension/aten_util/make_aten_functor_from_et_functor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,7 @@ struct type_convert<
}
c10::ScalarType scalar_type =
static_cast<c10::ScalarType>(val.scalar_type());
converted =
at::from_blob(val.mutable_data_ptr(), val.numel(), sizes, scalar_type);
converted = at::from_blob(val.mutable_data_ptr(), sizes, scalar_type);
}
ATensor call() {
return converted;
Expand Down
1 change: 1 addition & 0 deletions extension/aten_util/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ def define_common_targets():
],
exported_deps = [
"//executorch/extension/kernel_util:kernel_util",
"//executorch/extension/runner_util:managed_tensor",
"//executorch/runtime/core:core",
"//executorch/runtime/core:evalue",
"//executorch/runtime/core/exec_aten:lib",
Expand Down
2 changes: 1 addition & 1 deletion extension/kernel_util/meta_programming.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ struct is_compile_time_function_pointer<
CompileTimeFunctionPointer<FuncType, func_ptr>> : std::true_type {};

#define EXECUTORCH_FN_TYPE(func) \
CompileTimeFunctionPointer< \
::torch::executor::CompileTimeFunctionPointer< \
std::remove_pointer_t<std::remove_reference_t<decltype(func)>>, \
func>
#define EXECUTORCH_FN(func) EXECUTORCH_FN_TYPE(func)()
Expand Down