Skip to content

[ET-VK][EZ] Fix comment style for parameter names #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
junpi3 wants to merge 2 commits into from
Closed

[ET-VK][EZ] Fix comment style for parameter names #2847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4a3673
[ET-VK][EZ] Fix comment style for parameter names
Apr 4, 2024
fc1ac45
Update on "[ET-VK][EZ] Fix comment style for parameter names"
Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backends/vulkan/runtime/graph/ops/impl/UnaryOp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ float get_val_or_inf(ComputeGraph& graph, const ValueRef& val, bool max) {
return add_unary_op_node( \
graph, \
args[0], \
get_val_or_inf(graph, args[1], /*max =*/false), \
get_val_or_inf(graph, args[2], /*max =*/true), \
get_val_or_inf(graph, args[1], /*max = */ false), \
get_val_or_inf(graph, args[2], /*max = */ true), \
args[3], \
kClampShaderName); \
}
Expand Down
44 changes: 36 additions & 8 deletions backends/vulkan/test/vulkan_compute_api_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1044,11 +1044,39 @@ void test_mm(
}

TEST(VulkanComputeGraphOpsTest, mm_smoke_test) {
#define RUN_TESTS(dtype, layout, prepack) \
test_mm(/*B=*/1, /*M=*/31, /*K=*/127, /*N=*/23, dtype, layout, prepack); \
test_mm(/*B=*/5, /*M=*/31, /*K=*/127, /*N=*/23, dtype, layout, prepack); \
test_mm(/*B=*/7, /*M=*/13, /*K=*/89, /*N=*/17, dtype, layout, prepack); \
test_mm(/*B=*/1, /*M=*/13, /*K=*/89, /*N=*/17, dtype, layout, prepack);
#define RUN_TESTS(dtype, layout, prepack) \
test_mm( \
/*B = */ 1, \
/*M = */ 31, \
/*K = */ 127, \
/*N = */ 23, \
dtype, \
layout, \
prepack); \
test_mm( \
/*B = */ 5, \
/*M = */ 31, \
/*K = */ 127, \
/*N = */ 23, \
dtype, \
layout, \
prepack); \
test_mm( \
/*B = */ 7, \
/*M = */ 13, \
/*K = */ 89, \
/*N = */ 17, \
dtype, \
layout, \
prepack); \
test_mm( \
/*B = */ 1, \
/*M = */ 13, \
/*K = */ 89, \
/*N = */ 17, \
dtype, \
layout, \
prepack);

CALL_TEST_FN_FOR_W_PACKED(RUN_TESTS);
CALL_TEST_FN_FOR_C_PACKED(RUN_TESTS);
Expand Down Expand Up @@ -1102,7 +1130,7 @@ void test_max_pool2d(

// Run graph

fill_vtensor(graph, graph.inputs().at(0), base_val, /*iota=*/true);
fill_vtensor(graph, graph.inputs().at(0), base_val, /*iota = */ true);

vTensor& t_in = graph.get_val(in_ioval.value).toTensor();
std::vector<float> input_data(t_in.gpu_numel());
Expand Down Expand Up @@ -1140,7 +1168,7 @@ void test_max_pool2d(
TEST(VulkanComputeGraphOpsTest, max_pool2d_smoke_test) {
std::vector<int64_t> kernel = {2, 3};
test_max_pool2d(
/*in_size=*/{1, 4, 6},
/*base_val=*/10.0f,
/*in_size = */ {1, 4, 6},
/*base_val = */ 10.0f,
kernel);
}