fix et-view #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

metascroy wants to merge 1 commit into pytorch:main from metascroy:export-D55715318

Contributor

metascroy commented Apr 3, 2024

Summary: et-view should always copy the data pointer.

Differential Revision: D55715318

pytorch-bot bot commented Apr 3, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2843

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 712544d with merge base e641ffc ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Apr 3, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

facebook-github-bot added the fb-exported label

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

6a4355b

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

1dae308

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from 95a710b to 0127034 Compare

April 8, 2024 18:40

Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

fa5dd42

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

ff34696

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from 0127034 to ff34696 Compare

April 8, 2024 21:47

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

7a8b58e

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from ff34696 to 7a8b58e Compare

April 8, 2024 21:47

Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

1 similar comment

Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

6a47302

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

5fecf04

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from 7a8b58e to da9f35f Compare

April 9, 2024 17:38

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

da9f35f

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

Contributor

facebook-github-bot commented Apr 9, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

37f9795

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

4dfad81

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

dce1b7b

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

2a8aafa

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from da9f35f to 2a8aafa Compare

April 9, 2024 19:04

Contributor

facebook-github-bot commented Apr 9, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from 2a8aafa to 849f9bf Compare

April 9, 2024 20:18

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

849f9bf

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

6741c37

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from 3628a5e to 29d6260 Compare

April 11, 2024 01:31

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

29d6260

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

Contributor

facebook-github-bot commented Apr 11, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

cf4cb99

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

105e08c

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from 29d6260 to 105e08c Compare

April 11, 2024 01:32

Contributor

facebook-github-bot commented Apr 11, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

71c619e

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

77ceb8e

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

3bb5c0f

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

aaf677e

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from 105e08c to aaf677e Compare

April 11, 2024 16:39

Contributor

facebook-github-bot commented Apr 11, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318


          fix et-view (pytorch#2843)

712544d

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

191692b

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

fa64f93

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy force-pushed the export-D55715318 branch from aaf677e to 712544d Compare

April 11, 2024 16:40

Contributor

facebook-github-bot commented Apr 11, 2024

This pull request was exported from Phabricator. Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

ff57b72

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

8d32bd4

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

8eb9932

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

5bca236

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

JacobSzwejbka approved these changes

View reviewed changes

metascroy added a commit to metascroy/executorch that referenced this pull request


          fix et-view (pytorch#2843)

865c43a

Summary:

et-view should always copy the data pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D55715318

facebook-github-bot closed this in

1f6f711

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Apr 11, 2024

This pull request has been merged in 1f6f711.

mergennachin mentioned this pull request

disclaimer #3376

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged