-
Notifications
You must be signed in to change notification settings - Fork 705
Improve setup instructions #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5272718
Update README.md
msaroufim 2f3090a
Update setting_up_executorch.md
msaroufim 648a3ff
Update setup.py
msaroufim 799a583
remove warning spam from functorch
msaroufim f4e1682
more notification spam
msaroufim 3e0fde0
fix import in example
msaroufim 354aff5
1 more
msaroufim 12d3b05
Merge branch 'main' into patch-2
msaroufim e2bd3c4
make sure a file gets written in tutorial
msaroufim 800efda
Merge branch 'patch-2' of https://github.com/msaroufim/executorch int…
msaroufim 0160e51
ignore
msaroufim 5d7c8c1
revert local diretory changes'
msaroufim 46e8b07
Update setting_up_executorch.md
msaroufim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ git clone [email protected]:pytorch/executorch.git | |
| # [Runtime requirement] Run the following to get all submodules, only need for runtime setup | ||
| git submodule update --init --recursive | ||
|
|
||
| pip install executorch | ||
| pip install . | ||
|
|
||
| # cd into a directory that doesn't contain a `./executorch/exir` directory, since | ||
| # otherwise python will try using it for `import executorch.exir...` instead of using the | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,13 @@ | |
| from setuptools.command.egg_info import egg_info | ||
| from setuptools.command.install import install | ||
|
|
||
| # Dependencies | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. docs/website/docs/tutorials/setting_up_executorch.md mentions most of these dependencies so might as well install them |
||
| required_packages = [ | ||
| "numpy", | ||
| "zstd", | ||
| "flatbuffers", | ||
| # "torch_nightly" # This is not available on PyPI. Please install manually. | ||
| ] | ||
|
|
||
| def custom_command(): | ||
| src_dst_list = [ | ||
|
|
@@ -53,4 +60,5 @@ def run(self): | |
| "develop": CustomDevelopCommand, | ||
| "egg_info": CustomEggInfoCommand, | ||
| }, | ||
| install_requires=required_packages, | ||
| ) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strangely enough
pip install -e .was not findingexirfor me :/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think this is because there's something weird going on with the custom install instructions, will get back to this later