-
Notifications
You must be signed in to change notification settings - Fork 732
Qualcomm AI Engine Direct - Support PARSeq in floating point precision #15913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/1.0
Are you sure you want to change the base?
Qualcomm AI Engine Direct - Support PARSeq in floating point precision #15913
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15913
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Cancelled JobsAs of commit e5d085e with merge base e0dda90 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Thank you for putting up the PR! For the change in |
Yes, I created a new virtual environment and tried to reproduce the error by running pip install executorch. |
|
Hi @cccclai, From my experiment, the issue is related to dynamic_cast, where p_tensor_param becomes nullptr even when param is a TensorParamWrapper*. I also replaced dynamic_cast with the code below, and confirmed that the typeid of param matches Do you have any thoughts? Or do you have any concerns about loading the library with RTLD_LOCAL?” |
|
Hmm I feel like we should find a way to build both libraries with the same compiler + same C++ standard library + same ABI settings, it's actually quite important for next release, maybe need to figure out if there is a way to do that |
Summary: