Skip to content

Conversation

@jethroqti
Copy link
Contributor

Summary:
Enable max_pool3d operator by using max_pool2d two times

Test plan:
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNFloatingPointOperator.test_qnn_backend_max_pool3d -b build-android -H HOST -s DEVICE -m CHIPID
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_max_pool3d -b build-android -H HOST -s DEVICE -m CHIPID

Summary:
Enable max_pool3d operator by using max_pool2d two times

Test plan:
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNFloatingPointOperator.test_qnn_backend_max_pool3d -b build-android -H HOST -s DEVICE -m CHIPID
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQQuantizedOperator.test_qnn_backend_max_pool3d -b build-android -H HOST -s DEVICE -m CHIPID
@jethroqti jethroqti requested a review from cccclai as a code owner November 19, 2025 18:17
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15897

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures

As of commit 2eeac0c with merge base c6308a9 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2025
@jethroqti
Copy link
Contributor Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Nov 19, 2025
@jethroqti
Copy link
Contributor Author

@cccclai This PR is to enable max pooling 3D operator.
cc @haowhsu-quic

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants