-
Notifications
You must be signed in to change notification settings - Fork 730
Remove no-op clones #15838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove no-op clones #15838
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15838
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 2 Unrelated FailuresAs of commit 53136fa with merge base 101e915 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86588171. |
Summary: Pull Request resolved: pytorch#15838 Differential Revision: D86588171
7158b5e to
d2bc81d
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D86588171. |
d2bc81d to
374d228
Compare
Summary: Pull Request resolved: pytorch#15838 Differential Revision: D86588171 Pulled By: GregoryComer
Summary: Pull Request resolved: pytorch#15838 Differential Revision: D86588171 Pulled By: GregoryComer
374d228 to
2ef9db3
Compare
Summary: Pull Request resolved: pytorch#15838 Differential Revision: D86588171 Pulled By: GregoryComer
2ef9db3 to
cf3a6a3
Compare
Summary: Pull Request resolved: pytorch#15838 Differential Revision: D86588171 Pulled By: GregoryComer
cf3a6a3 to
788cc45
Compare
|
@MartinPavella @StrycekSimon I'm looking at optimizing out clones more aggressively from the graph during to_edge. I see that the NXP backend has some test coverage looking at clones in the context of the dropout op. Do you have any concerns with removal of clones from the graph? If not, I'm happy to take a pass at updating the tests accordingly. |
Summary: Pull Request resolved: pytorch#15838 Differential Revision: D86588171 Pulled By: GregoryComer
788cc45 to
53136fa
Compare
Differential Revision: D86588171