Skip to content

Conversation

@GregoryComer
Copy link
Member

Differential Revision: D86588171

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15838

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 2 Unrelated Failures

As of commit 53136fa with merge base 101e915 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 15, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 15, 2025

@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86588171.

@GregoryComer GregoryComer marked this pull request as draft November 15, 2025 01:55
@GregoryComer GregoryComer added the release notes: exir Changes to any dialects and passes on these dialects, such as memory planning label Nov 15, 2025
GregoryComer added a commit to GregoryComer/executorch that referenced this pull request Nov 15, 2025
Summary: Pull Request resolved: pytorch#15838

Differential Revision: D86588171
@GregoryComer GregoryComer changed the title Remove no-op clones (WIP) Remove no-op clones Nov 17, 2025
@GregoryComer GregoryComer marked this pull request as ready for review November 17, 2025 21:04
@meta-codesync
Copy link

meta-codesync bot commented Nov 17, 2025

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D86588171.

GregoryComer added a commit to GregoryComer/executorch that referenced this pull request Nov 17, 2025
Summary: Pull Request resolved: pytorch#15838

Differential Revision: D86588171

Pulled By: GregoryComer
GregoryComer added a commit to GregoryComer/executorch that referenced this pull request Nov 17, 2025
Summary: Pull Request resolved: pytorch#15838

Differential Revision: D86588171

Pulled By: GregoryComer
GregoryComer added a commit to GregoryComer/executorch that referenced this pull request Nov 18, 2025
Summary: Pull Request resolved: pytorch#15838

Differential Revision: D86588171

Pulled By: GregoryComer
GregoryComer added a commit to GregoryComer/executorch that referenced this pull request Nov 18, 2025
Summary: Pull Request resolved: pytorch#15838

Differential Revision: D86588171

Pulled By: GregoryComer
@GregoryComer
Copy link
Member Author

@MartinPavella @StrycekSimon I'm looking at optimizing out clones more aggressively from the graph during to_edge. I see that the NXP backend has some test coverage looking at clones in the context of the dropout op. Do you have any concerns with removal of clones from the graph? If not, I'm happy to take a pass at updating the tests accordingly.

@GregoryComer GregoryComer marked this pull request as draft November 18, 2025 22:53
Summary: Pull Request resolved: pytorch#15838

Differential Revision: D86588171

Pulled By: GregoryComer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: exir Changes to any dialects and passes on these dialects, such as memory planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant