Update ReplaceLogicalNotBooleanWhereWithWherePass to use new pass interface #15755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15755
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9c420a5 with merge base cf0e9aa ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Nov 11, 2025
…erface (pytorch#15755) Summary: As titled, more efficient now and properly updates the modified bit. Also, this pass was missing tests, so added some for a variety of different cases. Differential Revision: D86782910
DrJessop
force-pushed
the
export-D86782910
branch
from
11e6f32 to
1da8f01
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Nov 12, 2025
…erface (pytorch#15755) Summary: As titled, more efficient now and properly updates the modified bit. Also, this pass was missing tests, so added some for a variety of different cases. Differential Revision: D86782910
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Nov 12, 2025
…erface (pytorch#15755) Summary: As titled, more efficient now and properly updates the modified bit. Also, this pass was missing tests, so added some for a variety of different cases. Differential Revision: D86782910
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Nov 12, 2025
…erface (pytorch#15755) Summary: As titled, more efficient now and properly updates the modified bit. Also, this pass was missing tests, so added some for a variety of different cases. Differential Revision: D86782910
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Nov 12, 2025
…erface (pytorch#15755) Summary: As titled, more efficient now and properly updates the modified bit. Also, this pass was missing tests, so added some for a variety of different cases. Differential Revision: D86782910
abeakkas
approved these changes
Nov 13, 2025
Contributor
abeakkas
left a comment
abeakkas
left a comment
There was a problem hiding this comment.
With phabricator comments.
DrJessop
force-pushed
the
export-D86782910
branch
from
1da8f01 to
31b0412
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Nov 17, 2025
…erface (pytorch#15755) Summary: As titled, more efficient now and properly updates the modified bit. Also, this pass was missing tests, so added some for a variety of different cases. Reviewed By: abeakkas, hsharma35 Differential Revision: D86782910
…erface (pytorch#15755) Summary: As titled, more efficient now and properly updates the modified bit. Also, this pass was missing tests, so added some for a variety of different cases. Reviewed By: abeakkas, hsharma35 Differential Revision: D86782910
DrJessop
force-pushed
the
export-D86782910
branch
from
31b0412 to
9c420a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled, more efficient now and properly updates the modified bit. Also, this pass was missing tests, so added some for a variety of different cases.
Differential Revision: D86782910