Skip to content

Metal backend: Add MPSGraph caching #15346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 22, 2025
+279 −137
Merged

Metal backend: Add MPSGraph caching #15346

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d8e6d13
Update
manuelcandales Oct 22, 2025
00ba522
Update
manuelcandales Oct 22, 2025
136f908
Update
manuelcandales Oct 22, 2025
5bd34ee
Update
manuelcandales Oct 22, 2025
ee043e3
Update
manuelcandales Oct 22, 2025
fa097b8
Update
manuelcandales Oct 22, 2025
b29a39d
Update
manuelcandales Oct 22, 2025
33988a4
Update
manuelcandales Oct 22, 2025
f66ac9c
Update
manuelcandales Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions backends/apple/metal/runtime/shims/et_metal.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,12 +680,16 @@ int metal_copy_memory(void* dst, const void* src, size_t nbytes, bool src_is_dev

// Commit methods
void ETMetalStream::commit() {
if (enableCommitAndContinue_ && commandBuffer_) {
// Use commit-and-continue for better performance
commitAndContinue();
} else {
flush();
if (!commandBuffer_) {
ET_LOG(Error, "ETMetalStream::commit: No command buffer to commit");
return;
}

[commandBuffer_ commit];
ET_LOG(Debug, "ETMetalStream::commit: Committed buffer %p", commandBuffer_);

[commandBuffer_ release];
commandBuffer_ = nil;
}

void ETMetalStream::commitAndWait() {
Expand Down
Loading
Loading