Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the memory management and reference counting system for tensors in the Metal backend. The main change is the replacement of the previous ownership tracking (
is_tensor_own_memory
) with a more robust reference counting map (memory_to_n_tensor
), which tracks how many tensors share a memory address and whether the memory is owned or not. Additional improvements include safer tensor deletion, proper Metal buffer deallocation, and consistent handling of tensor views and resource cleanup.