Skip to content

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Oct 21, 2025

Summary

Handle dataPath = null case

Test plan

CI

cc @cbilgin

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15326

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Cancelled Jobs, 16 Pending, 1 Unrelated Failure

As of commit b386eec with merge base 58bd91c (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kirklandsign kirklandsign marked this pull request as ready for review October 21, 2025 21:19
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2025
@kirklandsign kirklandsign requested a review from Copilot October 21, 2025 21:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds null-safety handling for the dataPath parameter in the LlmModule constructor by conditionally creating an empty list when dataPath is null instead of passing null to List.of().

Key changes:

  • Modified the constructor to check if dataPath is null before creating the list
  • Reformatted the constructor call across multiple lines for better readability

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kirklandsign kirklandsign added module: android Issues related to Android code, build, and execution release notes: android Android Java and JNI code labels Oct 21, 2025
@kirklandsign kirklandsign requested a review from lucylq October 21, 2025 21:21
@kirklandsign kirklandsign merged commit 455639b into main Oct 21, 2025
144 of 153 checks passed
@kirklandsign kirklandsign deleted the datapath-null branch October 21, 2025 22:11
@github-project-automation github-project-automation bot moved this from Todo to Done in ExecuTorch Android Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: android Issues related to Android code, build, and execution release notes: android Android Java and JNI code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants