Relax verification on flat tensor #15313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce that the data loader size must be at least as large as the header size, not exactly. We are introducing a dual address data loader, which takes in two loaders, one for flatbuffer-only, and one for the full PTD file. The DualAddressDataLoader returns size as the combined size of both loaders. This will end up being larger than the PTD file size in the header. The new data loader allows users to address int64 and int32 at the same time. Differential Revision: [D85169688](https://our.internmc.facebook.com/intern/diff/D85169688/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15313
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit 119a0f8 with merge base 7349bb5 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lucylq
added a commit
that referenced
this pull request
Oct 21, 2025
Enforce that the data loader size must be at least as large as the header size, not exactly. We are introducing a dual address data loader, which takes in two loaders, one for flatbuffer-only, and one for the full PTD file. The DualAddressDataLoader returns size as the combined size of both loaders. This will end up being larger than the PTD file size in the header. The new data loader allows users to address int64 and int32 at the same time. Differential Revision: [D85169688](https://our.internmc.facebook.com/intern/diff/D85169688/) ghstack-source-id: 317712776 Pull Request resolved: #15313
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
JacobSzwejbka
approved these changes
Oct 21, 2025
meta-codesync
bot
merged commit 304c04e
into
gh/lucylq/121/base
145 of 156 checks passed
lucylq
added a commit
that referenced
this pull request
Oct 21, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #15313 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/121/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/121/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/121/orig Differential Revision: [D85169688](https://our.internmc.facebook.com/intern/diff/D85169688/) @diff-train-skip-merge Co-authored-by: lucylq <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Enforce that the data loader size must be at least as large as the header size, not exactly.
We are introducing a dual address data loader, which takes in two loaders, one for flatbuffer-only, and one for the full PTD file. The DualAddressDataLoader returns size as the combined size of both loaders. This will end up being larger than the PTD file size in the header.
The new data loader allows users to address int64 and int32 at the same time.
Differential Revision: D85169688