Skip to content

Runner logs #15279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

Runner logs #15279

merged 1 commit into from
Oct 21, 2025

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Oct 20, 2025 •
edited
Loading

Summary

Move some runner logs around.

  1. Move the stats so it doesn't interfere with generation
  2. Add a different message to end of generation to indicate we cut off because tokens, not because of eos

Test plan

lora demo

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15279

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 3 Unrelated Failures

As of commit 925b41c with merge base 7d4db45 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka
JacobSzwejbka reviewed Oct 20, 2025
View reviewed changes
extension/llm/runner/text_token_generator.h

// data-dependent terminating condition: we have n_eos_ number of EOS
if (eos_ids_->find(cur_token) != eos_ids_->end()) {
printf("\n");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not your change but weird we have a printf

JacobSzwejbka
JacobSzwejbka reviewed Oct 20, 2025
View reviewed changes
extension/llm/runner/text_token_generator.h
printf("\n");
ET_LOG(Info, "\nReached to the end of generation");
break;
return pos - start_pos;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put this in a variable and share it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh its in the loop. Nvm I guess

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving as-is, because one is inside a while loop and another is not.

@lucylq lucylq merged commit 8ce3095 into main Oct 21, 2025
219 of 235 checks passed
@lucylq lucylq deleted the lfq.runner-logs-2 branch October 21, 2025 23:20
lucylq added a commit that referenced this pull request Oct 23, 2025
@lucylq
Revert "Runner logs (#15279)"
b9fd3bc 
This reverts commit 8ce3095.
psiddh pushed a commit that referenced this pull request Oct 23, 2025
@lucylq
Revert "Runner logs (#15279)" (#15362)
bda5173 
This reverts commit 8ce3095.

### Summary
[PLEASE REMOVE] See [CONTRIBUTING.md's Pull
Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests)
for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a `Fixes
#<issue-id>` line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be
the upcoming release notes, please add a "Release notes: <area>" label.
For a list of available release notes labels, check out
[CONTRIBUTING.md's Pull
Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests).

### Test plan
[PLEASE REMOVE] How did you test this PR? Please write down any manual
commands you used and note down tests that you have written if
applicable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucylq @JacobSzwejbka