- 
                Notifications
    You must be signed in to change notification settings 
- Fork 698
Minor perf improvements to quantized mat mul shader. #15261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
        
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15261
 Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 2 Pending, 2 Unrelated FailuresAs of commit 3002776 with merge base 0dbf06e ( NEW FAILURES - The following jobs have failed:
 
 BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures 
 This comment was automatically generated by Dr. CI and updates every 15 minutes. | 
| @trivedivivek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84998542. | 
a5081fc    to
    c1ff85c      
    Compare
  
    
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 20, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Differential Revision: D84998542
c1ff85c    to
    2b1d9ae      
    Compare
  
    
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 20, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Differential Revision: D84998542
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 20, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Differential Revision: D84998542
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 20, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Differential Revision: D84998542
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 20, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Differential Revision: D84998542
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 20, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Differential Revision: D84998542
2b1d9ae    to
    b8d147e      
    Compare
  
    
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 20, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Differential Revision: D84998542
b8d147e    to
    196de84      
    Compare
  
    
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Differential Revision: D84998542
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Differential Revision: D84998542
196de84    to
    ed60f7c      
    Compare
  
    
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Differential Revision: D84998542
ed60f7c    to
    20be719      
    Compare
  
    
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Differential Revision: D84998542
            
                  SS-JIA
  
            
            approved these changes
            
                
                  Oct 21, 2025 
                
            
            
          
          
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Reviewed By: SS-JIA Differential Revision: D84998542
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Reviewed By: SS-JIA Differential Revision: D84998542
20be719    to
    ece3cf5      
    Compare
  
    
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Reviewed By: SS-JIA Differential Revision: D84998542
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Reviewed By: SS-JIA Differential Revision: D84998542
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Reviewed By: SS-JIA Differential Revision: D84998542
ece3cf5    to
    c689e56      
    Compare
  
    
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Reviewed By: SS-JIA Differential Revision: D84998542
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Reviewed By: SS-JIA Differential Revision: D84998542
    
  trivedivivek 
      added a commit
        to trivedivivek/executorch
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Reviewed By: SS-JIA Differential Revision: D84998542
c689e56    to
    67e2eb9      
    Compare
  
    Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader. Reviewed By: SS-JIA Differential Revision: D84998542
67e2eb9    to
    3002776      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    CLA Signed
  This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. 
  
    fb-exported
  
    meta-exported
  
    release notes: vulkan
  Changes to the Vulkan backend delegate 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Summary: The diff includes minor performance improvements to the quantized matrix multiplication shader.
Differential Revision: D84998542