Skip to content

Conversation

@kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Oct 17, 2025

Summary

Match const variable name in jni_layer_llama.cpp MODEL_TYPE_CATEGORY_MULTIMODAL

Test plan

CI

cc @cbilgin

@kirklandsign kirklandsign marked this pull request as ready for review October 17, 2025 19:22
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15230

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 65496a5 with merge base 173b046 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kirklandsign kirklandsign added module: android Issues related to Android code, build, and execution release notes: android Android Java and JNI code labels Oct 17, 2025
@kirklandsign kirklandsign merged commit 6f7d15e into main Oct 17, 2025
142 of 150 checks passed
@kirklandsign kirklandsign deleted the new-model-type-const branch October 17, 2025 21:06
@github-project-automation github-project-automation bot moved this from Todo to Done in ExecuTorch Android Oct 17, 2025
@GregoryComer
Copy link
Member

@pytorchbot cherry-pick --onto release/1.0 -c critical

pytorchbot pushed a commit that referenced this pull request Oct 17, 2025
Match const variable name in jni_layer_llama.cpp
`MODEL_TYPE_CATEGORY_MULTIMODAL`

(cherry picked from commit 6f7d15e)
@pytorchbot
Copy link
Collaborator

Cherry picking #15230

The cherry pick PR is at #15235 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: android Issues related to Android code, build, and execution release notes: android Android Java and JNI code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants