-
Notifications
You must be signed in to change notification settings - Fork 695
Remove internal executorch dependency on torchao.quantization.subclass #15223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15223
Note: Links to docs will display an error until the docs builds have been completed. ❌ 8 New Failures, 2 Unrelated FailuresAs of commit 01e01b0 with merge base 5076749 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@andrewor14 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84921134. |
This PR needs a
|
e910d6d to
7019ce6
Compare
pytorch#15223) Summary: **Summary:** This is a really old quantization API that we recently removed in torchao (D84842047). No one should be calling it anymore. For BC, let's just copy the base class into executorch for now. We should delete this in the future. **Test Plan:** CI Differential Revision: D84921134
pytorch#15223) Summary: **Summary:** This is a really old quantization API that we recently removed in torchao (D84842047). No one should be calling it anymore. For BC, let's just copy the base class into executorch for now. We should delete this in the future. **Test Plan:** CI Differential Revision: D84921134
7019ce6 to
c029373
Compare
pytorch#15223) Summary: **Summary:** This is a really old quantization API that we recently removed in torchao (D84842047). No one should be calling it anymore. For BC, let's just copy the base class into executorch for now. We should delete this in the future. **Test Plan:** CI Differential Revision: D84921134
e497573 to
1383528
Compare
pytorch#15223) Summary: **Summary:** This is a really old quantization API that we recently removed in torchao (D84842047). No one should be calling it anymore. For BC, let's just copy the base class into executorch for now. We should delete this in the future. **Test Plan:** CI bypass-github-export-checks Reviewed By: vkuzo Differential Revision: D84921134
| return a * scale.unsqueeze(1) | ||
|
|
||
|
|
||
| class QuantizedLinearWeightBase(torch.Tensor): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we tag this as deprecated?
from executorch.exir._warnings import deprecated
..
@deprecated("QuantizedLinearWeightBase is deleted from torchao ... ")
class QuantizedLinearWeightBase(torch.Tensor):
1383528 to
f3cae78
Compare
pytorch#15223) Summary: **Summary:** This is a really old quantization API that we recently removed in torchao (D84842047). No one should be calling it anymore. For BC, let's just copy the base class into executorch for now. We should delete this in the future. **Test Plan:** CI bypass-github-export-checks Reviewed By: vkuzo Differential Revision: D84921134
f3cae78 to
73940fe
Compare
pytorch#15223) Summary: **Summary:** This is a really old quantization API that we recently removed in torchao (D84842047). No one should be calling it anymore. For BC, let's just copy the base class into executorch for now. We should delete this in the future. **Test Plan:** CI bypass-github-export-checks Reviewed By: vkuzo Differential Revision: D84921134
pytorch#15223) Summary: **Summary:** This is a really old quantization API that we recently removed in torchao (D84842047). No one should be calling it anymore. For BC, let's just copy the base class into executorch for now. We should delete this in the future. **Test Plan:** CI bypass-github-export-checks Reviewed By: vkuzo Differential Revision: D84921134
73940fe to
31ab988
Compare
pytorch#15223) Summary: **Summary:** This is a really old quantization API that we recently removed in torchao (D84842047). No one should be calling it anymore. For BC, let's just copy the base class into executorch for now. We should delete this in the future. **Test Plan:** CI bypass-github-export-checks Reviewed By: vkuzo Differential Revision: D84921134
31ab988 to
a72846c
Compare
pytorch#15223) Summary: Pull Request resolved: pytorch#15223 **Summary:** This is a really old quantization API that we recently removed in torchao (D84842047). No one should be calling it anymore. For BC, let's just copy the base class into executorch for now. We should delete this in the future. **Test Plan:** CI bypass-github-export-checks Reviewed By: vkuzo Differential Revision: D84921134
a72846c to
01e01b0
Compare
Summary:
Summary: This is a really old quantization API that we
recently removed in torchao (D84842047). No one should be
calling it anymore. For BC, let's just copy the base class
into executorch for now. We should delete this in the future.
Test Plan: CI
Differential Revision: D84921134