Skip to content

Conversation

JacobSzwejbka
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka commented Oct 16, 2025

Summary: Has issues with MSVC, so reintroduce the minor boilerplate.

Differential Revision: D84844855

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15200

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 4 Pending

As of commit ee95a67 with merge base bdc9cef (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 16, 2025

@JacobSzwejbka has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84844855.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@shoumikhin
Copy link
Contributor

What was the issue?
It'd be nice to keep using the macro for brevity.

Summary:

Has issues with MSVC, so reintroduce the minor boilerplate.

Differential Revision: D84844855
@JacobSzwejbka JacobSzwejbka changed the title Remove ET_UNWRAP from module Remove ET_UNWRAP usage Oct 16, 2025
@JacobSzwejbka
Copy link
Contributor Author

What was the issue? It'd be nice to keep using the macro for brevity.

Statement expressions are not supported in msvc so in general its not very portable. I have run into issues with it on windows MSVC trying to set up the cuda voxtral demo.

@JacobSzwejbka JacobSzwejbka merged commit 4b7bea2 into pytorch:main Oct 16, 2025
143 of 147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants