-
Notifications
You must be signed in to change notification settings - Fork 693
Remove ET_UNWRAP usage #15200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ET_UNWRAP usage #15200
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15200
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 4 PendingAs of commit ee95a67 with merge base bdc9cef ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@JacobSzwejbka has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84844855. |
This PR needs a
|
What was the issue? |
Summary: Has issues with MSVC, so reintroduce the minor boilerplate. Differential Revision: D84844855
ceac4a9
to
ee95a67
Compare
Statement expressions are not supported in msvc so in general its not very portable. I have run into issues with it on windows MSVC trying to set up the cuda voxtral demo. |
Summary: Has issues with MSVC, so reintroduce the minor boilerplate.
Differential Revision: D84844855