Skip to content

Msvc inline macros #15197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 16, 2025
Merged

Msvc inline macros #15197

merged 7 commits into from
Oct 16, 2025

Conversation

@JacobSzwejbka
Copy link
Contributor

Summary

Add MSVC support to inline macro

Test plan

Manual testing for now. Will add CI support when I get a full msvc build working.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15197

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit e906d48 with merge base ad0ef31 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Gasoonjia
Gasoonjia approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@Gasoonjia Gasoonjia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trust you

swolchok
swolchok approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches c10, seems legit

@JacobSzwejbka JacobSzwejbka merged commit d588947 into main Oct 16, 2025
138 checks passed
@JacobSzwejbka JacobSzwejbka deleted the msvc-compiler-macros branch October 16, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swolchok swolchok swolchok approved these changes

@Gasoonjia Gasoonjia Gasoonjia approved these changes

@mergennachin mergennachin Awaiting requested review from mergennachin

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JacobSzwejbka @swolchok @Gasoonjia