-
Notifications
You must be signed in to change notification settings - Fork 700
Removing one shift op from quantized linear shader to improve perf. #15191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15191
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 6 Pending, 4 Unrelated FailuresAs of commit 98f71ba with merge base acd0636 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@trivedivivek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84679388. |
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 16, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 16, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 16, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 16, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
c32c900 to
df6b876
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 16, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
df6b876 to
3c421ef
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
SS-JIA
approved these changes
Oct 17, 2025
3c421ef to
117f060
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
117f060 to
f52df8a
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 18, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 18, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
f52df8a to
6e9b42b
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 18, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
6e9b42b to
e5c0820
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 18, 2025
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
e5c0820 to
1ea9d00
Compare
…ytorch#15191) Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance. Reviewed By: SS-JIA Differential Revision: D84679388
1ea9d00 to
98f71ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
meta-exported
release notes: vulkan
Changes to the Vulkan backend delegate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff removes a redundant mask op from 4 bit quantized linear shader to improve performance.
Reviewed By: SS-JIA
Differential Revision: D84679388