Moving scale fetch later for minor improvement. #15190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15190
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit ce9001a with merge base 06ea3d6 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@trivedivivek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84679168. |
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 16, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Differential Revision: D84679168
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 16, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Differential Revision: D84679168
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 16, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Differential Revision: D84679168
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 16, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Differential Revision: D84679168
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 16, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Differential Revision: D84679168
trivedivivek
force-pushed
the
export-D84679168
branch
from
5171a16 to
34858b6
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 16, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Differential Revision: D84679168
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 16, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Differential Revision: D84679168
trivedivivek
added
the
release notes: vulkan
trivedivivek
force-pushed
the
export-D84679168
branch
from
34858b6 to
765c703
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Reviewed By: yipjustin Differential Revision: D84679168
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Reviewed By: yipjustin Differential Revision: D84679168
trivedivivek
force-pushed
the
export-D84679168
branch
2 times, most recently
from
809afdf to
4d5e3b5
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Reviewed By: yipjustin Differential Revision: D84679168
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Reviewed By: yipjustin Differential Revision: D84679168
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Reviewed By: yipjustin Differential Revision: D84679168
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Reviewed By: yipjustin Differential Revision: D84679168
SS-JIA
approved these changes
Oct 17, 2025
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Reviewed By: yipjustin, SS-JIA Differential Revision: D84679168
trivedivivek
force-pushed
the
export-D84679168
branch
from
4d5e3b5 to
90ac024
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Reviewed By: yipjustin, SS-JIA Differential Revision: D84679168
trivedivivek
force-pushed
the
export-D84679168
branch
from
90ac024 to
eaaba57
Compare
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Reviewed By: yipjustin, SS-JIA Differential Revision: D84679168
trivedivivek
force-pushed
the
export-D84679168
branch
from
eaaba57 to
ce9001a
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Reviewed By: yipjustin, SS-JIA Differential Revision: D84679168
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Reviewed By: yipjustin, SS-JIA Differential Revision: D84679168
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 17, 2025
Summary: ### Summary The changes moves the scale fetch later in the code, which can provide a minor improvement. Reviewed By: yipjustin, SS-JIA Differential Revision: D84679168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Summary
The changes moves the scale fetch later in the code, which can provide a minor improvement.
Differential Revision: D84679168