Skip to content

Conversation

JacobSzwejbka
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka commented Oct 16, 2025

Summary

Abstract away posix apis which are not on windows.

Future PRs are coming quick. Should be a no-op for linux builds though and this file is under a lot of active refactoring and development so I want to quit having to rebase changes.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15183

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 9 Pending

As of commit 09b9355 with merge base e3e8e60 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JacobSzwejbka JacobSzwejbka changed the title platform layer for windows and linux compatibility platform layer for windows and linux compatibility in cuda_backend Oct 16, 2025
@larryliu0820
Copy link
Contributor

How do you test this?

@JacobSzwejbka
Copy link
Contributor Author

JacobSzwejbka commented Oct 16, 2025

How do you test this?

I have not tested the windows impl really (half of ET/extensions doesnt build with msvc yet). Linux is protected by CI though and the bigger thing to get through here is the refactor so that we dont keep merge conflicting each other.

@JacobSzwejbka JacobSzwejbka merged commit caa35f6 into main Oct 17, 2025
138 checks passed
@JacobSzwejbka JacobSzwejbka deleted the aoti-platform branch October 17, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants