-
Notifications
You must be signed in to change notification settings - Fork 694
platform layer for windows and linux compatibility in cuda_backend #15183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15183
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 9 PendingAs of commit 09b9355 with merge base e3e8e60 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
How do you test this? |
I have not tested the windows impl really (half of ET/extensions doesnt build with msvc yet). Linux is protected by CI though and the bigger thing to get through here is the refactor so that we dont keep merge conflicting each other. |
Summary
Abstract away posix apis which are not on windows.
Future PRs are coming quick. Should be a no-op for linux builds though and this file is under a lot of active refactoring and development so I want to quit having to rebase changes.