Skip to content

Conversation

winskuo-quic
Copy link
Collaborator

@winskuo-quic winskuo-quic commented Oct 16, 2025

Summary

  • Supports transpose_conv with per_channel_quant. Previously, transpose_conv per_channel_quant is not done correctly, as the channel should be ch_axis=1 instead of ch_axis=0.
  • Some test suite operators are using random values instead of desired input. These operations require specific range to prevent NaN as output.

Test plan

UT added

cc @cccclai @shewu-quic @haowhsu-quic @DannyYuyang-quic @cbilgin

@winskuo-quic winskuo-quic requested a review from cccclai as a code owner October 16, 2025 00:43
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15182

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 2 Unrelated Failures

As of commit 9953890 with merge base 50f96a0 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
This PR works on fixing conv_transpose per_channel quant. We should be able to get 5 or more conv_transpose tests fixed for each quant config.

Hi @GregoryComer
I have updated some suite_operator test that is using random input instead of desired random input. Please let me know if it makes sense to you.

Thanks

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2025

To add the ciflow label ciflow/nightly please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2025

To add the ciflow label ciflow/nightly please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@manuelcandales manuelcandales added partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Oct 16, 2025
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cccclai cccclai merged commit 810b8e8 into pytorch:main Oct 16, 2025
156 of 174 checks passed
@cccclai
Copy link
Contributor

cccclai commented Oct 16, 2025

@pytorchbot cherry-pick --onto release/1.0 -c regression

pytorchbot pushed a commit that referenced this pull request Oct 16, 2025
### Summary

- Supports transpose_conv with per_channel_quant. Previously,
transpose_conv per_channel_quant is not done correctly, as the channel
should be ch_axis=1 instead of ch_axis=0.
- Some test suite operators are using random values instead of desired
input. These operations require specific range to prevent `NaN` as
output.

### Test plan
UT added

cc @cccclai @shewu-quic @haowhsu-quic @DannyYuyang-quic @cbilgin

(cherry picked from commit 810b8e8)
@pytorchbot
Copy link
Collaborator

Cherry picking #15182

The cherry pick PR is at #15194 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants