-
Notifications
You must be signed in to change notification settings - Fork 695
Qualcomm AI Engine Direct - Suite operator fix part 3 #15182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qualcomm AI Engine Direct - Suite operator fix part 3 #15182
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15182
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 2 Unrelated FailuresAs of commit 9953890 with merge base 50f96a0 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
Hi @cccclai, Hi @GregoryComer Thanks |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
@pytorchbot cherry-pick --onto release/1.0 -c regression |
### Summary - Supports transpose_conv with per_channel_quant. Previously, transpose_conv per_channel_quant is not done correctly, as the channel should be ch_axis=1 instead of ch_axis=0. - Some test suite operators are using random values instead of desired input. These operations require specific range to prevent `NaN` as output. ### Test plan UT added cc @cccclai @shewu-quic @haowhsu-quic @DannyYuyang-quic @cbilgin (cherry picked from commit 810b8e8)
Cherry picking #15182The cherry pick PR is at #15194 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Summary
NaNas output.Test plan
UT added
cc @cccclai @shewu-quic @haowhsu-quic @DannyYuyang-quic @cbilgin