-
Notifications
You must be signed in to change notification settings - Fork 698
[CoreML] Add retry logic to database/key-value store #15170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15170
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 2 Cancelled JobsAs of commit ac16839 with merge base 3ccb6ab ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@metascroy has imported this pull request. If you are a Meta employee, you can view this in D84748624. |
7a9c80d to
ac16839
Compare
|
@cymbalrush can you have a look? |
|
@metascroy do we know for sure if the database file is being deleted? If the database file is being deleted, that’s concerning — the OS will not automatically remove files from the Application Support directory. If the application itself is deleting it, can we exclude this file from that process? Also, could we log the SQLite error code to confirm what’s actually failing? is it failing when the app is backgrounded? |
This PR introduces changes to the database and key-value store to retry if there are certain kinds of failures.
I've confirmed it can recover and re-create the DB if the DB is deleted during predictions.
The "std::cout" statements will be removed before landing.