Skip to content

Conversation

@pytorchbot
Copy link
Collaborator

Summary: Also, let multimodal runner accept image/audio data as floats too

Differential Revision: D84001548

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14837

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Cancelled Job, 3 Pending

As of commit 8f29449 with merge base e0dda90 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2025
@GregoryComer GregoryComer force-pushed the cherry-pick-14825-by-pytorch_bot_bot_ branch from 809924c to e21b614 Compare October 8, 2025 18:52
@GregoryComer
Copy link
Member

Rebasing to see if later picks resolve the build issue.

Differential Revision: D84001548

Pull Request resolved: #14825

(cherry picked from commit d8a2126)
@GregoryComer GregoryComer force-pushed the cherry-pick-14825-by-pytorch_bot_bot_ branch from e21b614 to 19d2230 Compare October 9, 2025 18:24
@GregoryComer
Copy link
Member

@shoumikhin Do you have a recommendation to fix this build error? Thanks.

/Users/runner/work/executorch/executorch/pytorch/executorch/extension/llm/apple/ExecuTorchLLM/Exported/ExecuTorchLLMMultimodalRunner.mm:250:58: error: no matching constructor for initialization of 'llm::Audio'
          nativeInputs.emplace_back(llm::MultimodalInput(llm::Audio(
                                                         ^
In file included from /Users/runner/work/executorch/executorch/pytorch/executorch/extension/llm/apple/ExecuTorchLLM/Exported/ExecuTorchLLMMultimodalRunner.mm:13:
In file included from /Users/runner/work/executorch/executorch/pytorch/executorch/extension/llm/runner/multimodal_runner.h:24:
In file included from /Users/runner/work/executorch/executorch/pytorch/executorch/extension/llm/runner/irunner.h:18:
In file included from /Users/runner/work/executorch/executorch/pytorch/executorch/extension/llm/runner/stats.h:11:
In file included from /Users/runner/work/executorch/executorch/pytorch/executorch/extension/llm/runner/util.h:11:
In file included from /Users/runner/work/executorch/executorch/pytorch/executorch/extension/llm/runner/multimodal_prefiller.h:15:
In file included from /Users/runner/work/executorch/executorch/pytorch/executorch/extension/llm/runner/multimodal_input.h:14:
/Users/runner/work/executorch/executorch/pytorch/executorch/extension/llm/runner/audio.h:35:24: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 4 were provided
struct ET_EXPERIMENTAL Audio {
                       ^
/Users/runner/work/executorch/executorch/pytorch/executorch/extension/llm/runner/audio.h:35:24: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 4 were provided
/Users/runner/work/executorch/executorch/pytorch/executorch/extension/llm/runner/audio.h:35:24: note: candidate constructor (the implicit default constructor) not viable: requires 0 arguments, but 4 were provided

@shoumikhin
Copy link
Contributor

@GregoryComer it fails because of the lack of another cherry-pick
@larryliu0820 knows which one exactly

@GregoryComer GregoryComer merged commit 93ad679 into release/1.0 Oct 14, 2025
119 of 122 checks passed
@GregoryComer GregoryComer deleted the cherry-pick-14825-by-pytorch_bot_bot_ branch October 14, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants