-
Notifications
You must be signed in to change notification settings - Fork 700
Extend FuseViewCopyTransform to fuse more views #14745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Extends the pass to find chains of unary elementwise ops and fuse all views in each chain. This gives the same result since the shape does not matter for elementwise ops. This change allows to fuse patterns like view -> clone -> view. Signed-off-by: Adrian Lundell <[email protected]> Change-Id: I41afdbebf27124fa474e02180725ff28660ffef1
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14745
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 7 New Failures, 41 Unrelated FailuresAs of commit 64b0337 with merge base d00279d ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Fails not related. |
|
@digantdesai Do you think this is OK to add to the general pass or should I move it to the arm backend? |
Signed-off-by: Adrian Lundell <[email protected]>
|
Let me make sure internal CI is happy since it has a wider surface |
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this in D84515834. |
|
Internal tests are OK |
|
Thansk for testing, mergin! |
Extends the pass to find chains of unary elementwise ops and fuse all views in each chain. This gives the same result since the shape does not matter for elementwise ops.
This change allows to fuse patterns like view -> clone -> view.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai @psiddh