Skip to content

Conversation

@AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Oct 2, 2025

Extends the pass to find chains of unary elementwise ops and fuse all views in each chain. This gives the same result since the shape does not matter for elementwise ops.

This change allows to fuse patterns like view -> clone -> view.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai @psiddh

Extends the pass to find chains of unary elementwise ops
and fuse all views in each chain. This gives the same result
since the shape does not matter for elementwise ops.

This change allows to fuse patterns like view -> clone -> view.

Signed-off-by: Adrian Lundell <[email protected]>
Change-Id: I41afdbebf27124fa474e02180725ff28660ffef1
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Oct 2, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14745

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 7 New Failures, 41 Unrelated Failures

As of commit 64b0337 with merge base d00279d (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2025
@AdrianLundell
Copy link
Collaborator Author

Fails not related.

@AdrianLundell
Copy link
Collaborator Author

@digantdesai Do you think this is OK to add to the general pass or should I move it to the arm backend?

@digantdesai
Copy link
Contributor

Let me make sure internal CI is happy since it has a wider surface

@meta-codesync
Copy link

meta-codesync bot commented Oct 13, 2025

@digantdesai has imported this pull request. If you are a Meta employee, you can view this in D84515834.

@digantdesai digantdesai added module: microcontrollers For embedded MCUs like Cortex-M, or RTOS like Zephyr, does not track NPU backend like Arm Ethos. and removed module: microcontrollers For embedded MCUs like Cortex-M, or RTOS like Zephyr, does not track NPU backend like Arm Ethos. labels Oct 13, 2025
@digantdesai
Copy link
Contributor

Internal tests are OK

@zingo
Copy link
Collaborator

zingo commented Oct 17, 2025

Thansk for testing, mergin!

@zingo zingo merged commit ace0bf0 into pytorch:main Oct 17, 2025
245 of 300 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants