Migrate from cpp_python_extension to runtime.cxx_python_extension #14154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

swolchok merged 6 commits into main from gh/swolchok/562/head

Sep 11, 2025

Contributor

swolchok commented Sep 10, 2025 •

edited

Loading

We should be going through the runtime_wrapper for everything IIUC.

Differential Revision: D82127664

Contributor Author

swolchok commented Sep 10, 2025 •

edited

Loading

Stack from ghstack (oldest at bottom):

swolchok requested review from JacobSzwejbka and larryliu0820 as code owners

September 10, 2025 16:06

pytorch-bot bot commented Sep 10, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14154

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 271 Pending, 1 Unrelated Failure

As of commit a8ee90e with merge base 8358516 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / test-huggingface-transformers-macos (smollm2-135m|coreml_fp32_gpu|--quantize) / macos-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok mentioned this pull request

Mass migrate to runtime.python_library #14153

Merged

meta-cla bot added the CLA Signed label

This was referenced Sep 10, 2025

runtime_wrapper: remove caffe2 deps from python libraries so we can at least use buck query #14155

Merged

backends/arm buck fixup #14156

Merged

buck query most of //backends/arm in CI #14157

Merged

swolchok added the release notes: none label

JacobSzwejbka approved these changes

View reviewed changes

Contributor Author

swolchok commented Sep 10, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

3 similar comments

Contributor Author

swolchok commented Sep 10, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Contributor Author

swolchok commented Sep 10, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Contributor Author

swolchok commented Sep 10, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

swolchok mentioned this pull request

Allow PUBLIC visibility and make it the default #14181

Merged

Contributor Author

swolchok commented Sep 10, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

4 similar comments

Contributor Author

swolchok commented Sep 11, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Contributor Author

swolchok commented Sep 11, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Contributor Author

swolchok commented Sep 11, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Contributor Author

swolchok commented Sep 11, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Base automatically changed from gh/swolchok/561/head to main

September 11, 2025 16:28

facebook-github-bot requested review from Gasoonjia, SS-JIA, cccclai, digantdesai, jackzhxng, kirklandsign, lucylq and mergennachin as code owners

September 11, 2025 16:28

swolchok added 6 commits

September 11, 2025 13:30


          Update

103343b

[ghstack-poisoned]


          Update

f843b99

[ghstack-poisoned]


          Update

9ddc537

[ghstack-poisoned]


          runtime_wrapper: remove caffe2 deps from python libraries so we can a…

af30de1

…t least use buck query

Differential Revision: D82127663

Pull Request resolved: #14155


          backends/arm buck fixup

7ebf9ca

Differential Revision: D82127665

Pull Request resolved: #14156


          buck query most of //backends/arm in CI

a8ee90e

Differential Revision: D82127666

Pull Request resolved: #14157

swolchok force-pushed the gh/swolchok/562/head branch from 493de66 to a8ee90e Compare

September 11, 2025 20:36

Contributor Author

swolchok commented Sep 11, 2025

this was supposed to get merged automatically but there appears to have been a spurious conflict; will merge as soon as required jobs come back

swolchok merged commit 6d8583d into main

280 of 289 checks passed

swolchok deleted the gh/swolchok/562/head branch

September 11, 2025 20:56

swolchok added a commit that referenced this pull request


          Revert "Migrate from cpp_python_extension to runtime.cxx_python_exten…

d468c28

…sion (#14154)"

This reverts commit 6d8583d. Something went wrong with the automated merge of it + several PRs stacked on it initially, and my attempt to recover merged an old version.


ghstack-source-id: a148994
ghstack-comment-id: 3282883199
Pull-Request: #14233

swolchok added a commit that referenced this pull request


          Revert "Migrate from cpp_python_extension to runtime.cxx_python_exten…

b23f883

…sion (#14154)" (#14233)

This reverts commit 6d8583d. Something
went wrong with the automated merge of it + several PRs stacked on it
initially, and my attempt to recover merged an old version.

swolchok added a commit that referenced this pull request


          Manual merge of #14154 (#14234)

Something went wrong with the automated merge here. This is an exact
export of the corresponding diff.

Differential Revision: D82127664

swolchok added a commit that referenced this pull request


          Manual merge of #14154, second try (#14264)

8fe6227

Something went wrong with the automated merge here as well as the first
manual merge. This is an exact export of the corresponding diff.

Differential Revision: D82127664

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request


          Migrate from cpp_python_extension to runtime.cxx_python_extension (py…

2bdd509

…torch#14154)

We should be going through the runtime_wrapper for everything IIUC.

Differential Revision:
[D82127664](https://our.internmc.facebook.com/intern/diff/D82127664)

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request


          Revert "Migrate from cpp_python_extension to runtime.cxx_python_exten…

54154bb

…sion (pytorch#14154)" (pytorch#14233)

This reverts commit 6d8583d. Something
went wrong with the automated merge of it + several PRs stacked on it
initially, and my attempt to recover merged an old version.

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request


          Manual merge of pytorch#14154 (pytorch#14234)

d114125

Something went wrong with the automated merge here. This is an exact
export of the corresponding diff.

Differential Revision: D82127664

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request


          Manual merge of pytorch#14154, second try (pytorch#14264)

981b5f5

Something went wrong with the automated merge here as well as the first
manual merge. This is an exact export of the corresponding diff.

Differential Revision: D82127664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JacobSzwejbka JacobSzwejbka approved these changes

larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

kirklandsign Awaiting requested review from kirklandsign

jackzhxng Awaiting requested review from jackzhxng

mergennachin Awaiting requested review from mergennachin

cccclai Awaiting requested review from cccclai

lucylq Awaiting requested review from lucylq lucylq is a code owner

Gasoonjia Awaiting requested review from Gasoonjia Gasoonjia is a code owner

digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

SS-JIA Awaiting requested review from SS-JIA

Labels

CLA Signed release notes: none