Skip to content

Conversation

@jmahbs
Copy link
Contributor

@jmahbs jmahbs commented Sep 5, 2025

This PR exposes the Model Explorer visualisation API, which provides the foundation to enable us to load custom file types and plugins.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Change-Id: I64a01aba413d9d448690da621d5f79b78ecec5a7
@jmahbs jmahbs requested a review from Gasoonjia as a code owner September 5, 2025 13:29
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14005

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 4 Cancelled Jobs

As of commit a104159 with merge base fbdee8f (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Sep 5, 2025

Hi @jmahbs!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@jmahbs
Copy link
Contributor Author

jmahbs commented Sep 5, 2025

@pytorchbot label ciflow/trunk
@pytorchbot partner: arm
@pytorchbot release notes: arm

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2025

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Sep 5, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/trunk label Sep 5, 2025
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add rationale for the change in the PR summary. Thanks.

@zingo zingo modified the milestone: 1.0.0 Sep 9, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 10, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@zingo zingo added the release notes: none Do not include this in the release notes label Sep 10, 2025
@zingo
Copy link
Collaborator

zingo commented Sep 10, 2025

Test fails seems unrelated and appear on other PRs

@zingo zingo merged commit 4d6209b into pytorch:main Sep 10, 2025
450 of 463 checks passed
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
This PR exposes the Model Explorer visualisation API, which provides the
foundation to enable us to load custom file types and plugins.
@jmahbs jmahbs deleted the expose-model-explorer-api branch September 30, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants