support function + method variants #10974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously think we didnt need this so just threw an exception. Now we are adding index_put_ and other inplace ops besides copy_ (which is only function variant) so adding it. Differential Revision: D75006941
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10974
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4537cd1 with merge base de72d65 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75006941 |
JacobSzwejbka
added
the
release notes: none
larryliu0820
approved these changes
May 19, 2025
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
May 19, 2025
Differential Revision: D75006941 Pull Request resolved: pytorch#10974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously think we didnt need this so just threw an exception. Now we are adding index_put_ and other inplace ops besides copy_ (which is only function variant) so adding it.
Differential Revision: D75006941