Skip to content

Conversation

@gggekov
Copy link
Collaborator

@gggekov gggekov commented May 19, 2025

Temporary solution to the problem in #10958 The arm_executor_runner.cpp need to declare the ethosu_fast_scratch array and pass it onto to the EthosUBackend.cpp. It is important that for Shared_Sram, the ethosu_fast_scratch is nullptr and for Dedicated_Sram it points to the fast memory array.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Temporary solution to the problem in pytorch#10958
The arm_executor_runner.cpp need to declare the ethosu_fast_scratch array and
pass it onto to the EthosUBackend.cpp. It is important that for Shared_Sram,
the ethosu_fast_scratch is nullptr and for Dedicated_Sram it points to the
fast memory array.

Change-Id: I808203fb7b9b6e5bece92c4cc5079f22bd802d95
@gggekov gggekov requested a review from digantdesai as a code owner May 19, 2025 14:50
@pytorch-bot
Copy link

pytorch-bot bot commented May 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10973

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 66f3859 with merge base 6ad47df (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 19, 2025
@gggekov gggekov changed the title Make the CI green by not testing Dedicated_Sram for the Ethos-U85 Arm backend: Make the CI green by not testing Dedicated_Sram for the Ethos-U85 May 19, 2025
@gggekov gggekov added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels May 19, 2025
@zingo zingo added the release notes: none Do not include this in the release notes label May 19, 2025
@gggekov
Copy link
Collaborator Author

gggekov commented May 19, 2025

CC @kirklandsign

@zingo zingo merged commit 9aedbeb into pytorch:main May 19, 2025
191 of 193 checks passed
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request May 19, 2025
…Ethos-U85 (pytorch#10973)

Temporary solution to the problem in
pytorch#10958 The
arm_executor_runner.cpp need to declare the ethosu_fast_scratch array
and pass it onto to the EthosUBackend.cpp. It is important that for
Shared_Sram, the ethosu_fast_scratch is nullptr and for Dedicated_Sram
it points to the fast memory array.
@zingo zingo mentioned this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants