Skip to content

Conversation

@jathu
Copy link
Contributor

@jathu jathu commented May 8, 2025

Summary

In this diff we create a helper that will allow presets to set options. Again this is mostly a helper to check if the option has been defined already, then no-oping.

To test it, I also create the first preset macos-arm64. I will test it in upcoming diffs.

Test plan

pytest for now, manual test in future diffs

cc @larryliu0820

@pytorch-bot
Copy link

pytorch-bot bot commented May 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10767

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures

As of commit 0f51701 with merge base a37b369 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2025
@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. topic: not user facing and removed release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels May 8, 2025
Base automatically changed from jathu/announce-option to main May 8, 2025 17:14
@jathu jathu force-pushed the jathu/set-option branch from 9d3a26a to b210d7c Compare May 8, 2025 17:16
@jathu jathu requested a review from larryliu0820 May 8, 2025 17:16
@jathu jathu marked this pull request as ready for review May 8, 2025 17:16
@jathu jathu force-pushed the jathu/set-option branch from b210d7c to 9460e99 Compare May 8, 2025 18:00
@jathu jathu merged commit 380c4f1 into main May 8, 2025
193 of 195 checks passed
@jathu jathu deleted the jathu/set-option branch May 8, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants