Skip to content

Automatically announce declared options #10766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Automatically announce declared options #10766

merged 1 commit into from
May 8, 2025

Conversation

@jathu
Copy link
Contributor

@jathu jathu commented May 8, 2025 •
edited by pytorch-bot bot
Loading

Summary

Instead of manually printing all the options in tools/cmake/Utils.cmake, let's just "automatically" print all the configured options.

Test plan

$ ./scripts/build_apple_frameworks.sh --Debug

-- --- Configurated Options ---

-- EXECUTORCH_ENABLE_LOGGING : ON
-- ---------------------------


$ ./scripts/build_apple_frameworks.sh --Release

-- --- Configurated Options ---

-- EXECUTORCH_ENABLE_LOGGING : OFF
-- ---------------------------

cc @larryliu0820

@jathu jathu requested a review from larryliu0820 May 8, 2025 02:21
@pytorch-bot
Copy link

pytorch-bot bot commented May 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10766

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit ef4e5c4 with merge base bf5b99a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2025
@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels May 8, 2025
@jathu jathu marked this pull request as ready for review May 8, 2025 02:44
larryliu0820
larryliu0820 reviewed May 8, 2025
View reviewed changes
tools/cmake/common/preset.cmake
Comment on lines +46 to +49
while(num_spaces GREATER 0)
set(padding "${padding} ")
math(EXPR num_spaces "${num_spaces} - 1")
endwhile()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent 5 mins reading this and just realized it's printing empty spaces lol

@jathu jathu merged commit 6346bfd into main May 8, 2025
85 of 87 checks passed
@jathu jathu deleted the jathu/announce-option branch May 8, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jathu @larryliu0820 @facebook-github-bot