Skip to content

Convert the unit test from java to kotlin #10702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2025
Merged

Convert the unit test from java to kotlin #10702

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b75a79
Convert the unit test from java to kotlin
May 3, 2025
a1dddbd
Convert the unit test from java to kotlin
May 3, 2025
44e263e
Update androidx.core:core-ktx version to be compatible with sdk 34
May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions extension/android/executorch_android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
plugins {
id "com.android.library" version "8.9.0"
id "com.vanniktech.maven.publish" version "0.31.0"
alias(libs.plugins.jetbrains.kotlin.android)
}

android {
Expand All @@ -34,6 +35,9 @@ android {
resources.srcDirs += [ 'src/androidTest/resources' ]
}
}
kotlinOptions {
jvmTarget = '17'
Copy link
Contributor

@kirklandsign kirklandsign May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now we have

    compileOptions {
        sourceCompatibility = JavaVersion.VERSION_1_8
        targetCompatibility = JavaVersion.VERSION_1_8
    }

is 1.8 possible? Otherwise we make everything 17?

Copy link
Contributor Author

@phaiting phaiting May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should make it to use 1.8 for kotlin compiler as well for the compatibility, will update.

}
}

task copyTestRes(type: Exec) {
Expand All @@ -43,6 +47,7 @@ task copyTestRes(type: Exec) {
dependencies {
implementation 'com.facebook.fbjni:fbjni:0.5.1'
implementation 'com.facebook.soloader:nativeloader:0.10.5'
implementation libs.core.ktx
testImplementation 'junit:junit:4.12'
androidTestImplementation 'androidx.test.ext:junit:1.1.5'
androidTestImplementation 'androidx.test:rules:1.2.0'
Expand Down
230 changes: 0 additions & 230 deletions extension/android/executorch_android/src/test/java/org/pytorch/executorch/EValueTest.java
View file
Open in desktop

This file was deleted.

Loading
Loading