Skip to content

Conversation

@oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Apr 29, 2025

Step vela pin and remove all related pytest.mark_flaky in sigmoid int16 and int32 tests.

cc @digantdesai @freddan80 @per @zingo

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10548

Note: Links to docs will display an error until the docs builds have been completed.

❌ 20 New Failures, 8 Unrelated Failures

As of commit 43cec8e with merge base e1738cc (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 29, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Apr 29, 2025
@zingo
Copy link
Collaborator

zingo commented Apr 29, 2025

@digantdesai this is also steping Vela (e.g. it's newer then #9893 ) Maybe you want to merge both PRs at the same time using the version of Vela from this PR.

EDIT we need to update this PR a bit more @digantdesai do not merge it yet

@oscarandersson8218
Copy link
Collaborator Author

Need to investigate some of the failures.

@oscarandersson8218
Copy link
Collaborator Author

@digantdesai @zingo It's now been resolved and is ready for review again. A few depthwise_conv2d tests started failing in different way than before so had to update those.

@zingo
Copy link
Collaborator

zingo commented May 6, 2025

@digantdesai we think this is ready and should work now. This will improve INT-16 tables so it will be interesting to get this in.

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@zingo
Copy link
Collaborator

zingo commented May 8, 2025

Hi unfortunately it got a merge conflict and probably needs to be rebased after #10776 was merged.
Sorry about that.

@oscarandersson8218 oscarandersson8218 force-pushed the sigmoid_flaky_fix branch 2 times, most recently from c8a0764 to 14d4e1b Compare May 13, 2025 07:26
@oscarandersson8218 oscarandersson8218 added release notes: none Do not include this in the release notes and removed topic: not user facing labels May 13, 2025
MLBEDSW-10642 has now been resolved. Step vela pin and remove all
related pytest.mark_flaky in sigmoid int16 and int32 tests. Also enables
quantized Conformer.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I8c1aff31fb173fa6fdebc1d5b757623f9c2e1321
@zingo
Copy link
Collaborator

zingo commented May 13, 2025

@digantdesai does this work now and can be merged?

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

Yeah looks good internally, feel free to merge. CI failures looks unrelated?

@zingo zingo merged commit a0d9c7e into pytorch:main May 16, 2025
161 of 190 checks passed
@zingo
Copy link
Collaborator

zingo commented May 16, 2025

Thanks for the help!

@zingo
Copy link
Collaborator

zingo commented May 16, 2025

Yes those fails was a geneal llama errors a few days ago that has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants