Skip to content

Arm backend: Convert asserts to raise errors in op_bmm #10424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

Arm backend: Convert asserts to raise errors in op_bmm #10424

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7090206
Arm backend: Convert asserts to raise errors in op_bmm
Sebastian-Larsson Apr 11, 2025
e01d605
Merge branch 'main' into assert_bmm
zingo Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions backends/arm/operators/op_bmm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,24 @@ def define_node(
inputs: List[TosaArg],
output: TosaArg,
) -> None:
if inputs[0].dtype != inputs[1].dtype or inputs[0].dtype != output.dtype:
raise TypeError(
f"All IO needs to have the same data type, got: "
f"{inputs[0].dtype=}, {inputs[1].dtype=} and {output.dtype=}"
)

assert inputs[0].dtype == inputs[1].dtype, "Both inputs must be of same type"
assert inputs[0].dtype in [
ts.DType.INT8,
ts.DType.FP32,
], "Only int8 and float32 supported"
# aten.bmm maps directly to MATMUL
# NOTE: For now, only INT8 & FP32 is supported
supported_dtypes = [ts.DType.INT8, ts.DType.FP32]
for input in inputs:
if input.dtype not in supported_dtypes:
raise TypeError(
f'IO data type needs to be {supported_dtypes}, got "{input.dtype}"'
)

# aten.bmm maps directly to MATMUL

# For INT8, we need to get the zero points and add an intermediate tensor
# for a later rescale.

if inputs[0].dtype == ts.DType.INT8:
input_qparams = get_input_qparams(node)
input0_zp = input_qparams[0].zp
Expand Down
Loading